Repository navigation
Template 0.1.33: Tools v0.3.0-alpha.3, and the right version and icon in the Windows Apps list - #57
Merged
Merged
Conversation
Tools v0.3.0-alpha.3 writes result images of 3 or 4 planes as grey pages, so Fiji opens them (LabConstrictor-Tools #163). The migration moves LC_TOOLS_PIN in post_install.sh and .bat from v0.3.0-alpha.2 to v0.3.0-alpha.3 only where the line still holds the template's old value. tests/_v0_1_33.py moves the pin back for the older migrations' tests. Merge only after the tag v0.3.0-alpha.3 exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184
…d the app icon post_install.bat registered the app in Settings > Apps with the version given at initialisation (no release changed it: bump_version.py looks for a PKG_VERSION line the script no longer has) and the icon logo.ico, which no installer contains. VLab4Mic showed 0.1.3 after installing 0.1.8, without an icon. The script now reads the version from the bundled construct.yaml at install time (the initialisation value stays as a fallback) and uses the first .ico the installer copied; without one it writes no icon entry. The 0.1.33 migration replaces only the template's exact lines and keeps the app's own version. The Windows smoke test checks the registry entry (version 1.2.3 from construct.yaml, not the 0.0.1 of initialisation). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184
guijacquemet
marked this pull request as ready for review
November 17, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: merge only after the tag
v0.3.0-alpha.3exists in LabConstrictor-Tools. The maintainer creates that tag after CellMigrationLab/LabConstrictor-Tools#164 merges. Until then the smoke-install jobs fail, because they install the pinned tag; that's also what runs the Windows check below.1. Tools v0.3.0-alpha.3
Tools v0.3.0-alpha.2 wrote a result image with exactly 3 or 4 planes (3 channels, 3 timepoints) as one page of colour samples, which Fiji can't open unless it's 8-bit. For example, Fast4DRegPy's Align channels on a 3-channel image showed nothing in Fiji. v0.3.0-alpha.3 writes such images as grey planes (CellMigrationLab/LabConstrictor-Tools#163).
The migration moves
LC_TOOLS_PINinpost_install.sh/.batfromv0.3.0-alpha.2tov0.3.0-alpha.3, only where the line still holds the template's old value. An app's own pin is left alone and logged. This is the same code as the 0.1.28 pin move.2. Windows Apps list: version and icon
post_install.batregistered the app in Settings > Apps with:bump_version.pylooks for aPKG_VERSIONline the script no longer has), andlogo.ico, which no installer contains.VLab4Mic, for example, showed 0.1.3 after installing 0.1.8, without an icon.
The script now reads the version at install time from the bundled
construct.yaml, keeping the initialisation value as a fallback. It uses the first.icothe installer copied, and writes no icon entry when there is none. The migration replaces only the template's exact lines and keeps the app's own version; a block changed by hand is left alone, with a note. CRLF line endings are preserved.Tests
test_template_sync_0_1_33.pycovers: the pin, the Apps-list block, an own pin, a hand-changed block, the app's version kept, idempotence, and the sync script.tests/_v0_1_33.pyundoes both changes for the older migrations' tests;test_template_sync_0_1_28.pynow compares through itslive()helper.tests/smoke/post_install_hosts.py(Windows): reads the registry back and expects version 1.2.3 fromconstruct.yaml, not the initialisation 0.0.1, and the copied.ico.LC_TOOLS_SPECset to the Tools checkout. The.batchanges are exercised only by the Windows smoke job, once the tag exists.🤖 Generated with Claude Code
https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184