Skip to content

Template 0.1.33: Tools v0.3.0-alpha.3, and the right version and icon in the Windows Apps list - #57

Merged
guijacquemet merged 2 commits into
mainfrom
claude/keen-mendel-ekvei7
Nov 17, 2026
Merged

guijacquemet merged 2 commits into
mainfrom
claude/keen-mendel-ekvei7

Conversation

@guijacquemet

@guijacquemet guijacquemet commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Draft: merge only after the tag v0.3.0-alpha.3 exists in LabConstrictor-Tools. The maintainer creates that tag after CellMigrationLab/LabConstrictor-Tools#164 merges. Until then the smoke-install jobs fail, because they install the pinned tag; that's also what runs the Windows check below.

1. Tools v0.3.0-alpha.3

Tools v0.3.0-alpha.2 wrote a result image with exactly 3 or 4 planes (3 channels, 3 timepoints) as one page of colour samples, which Fiji can't open unless it's 8-bit. For example, Fast4DRegPy's Align channels on a 3-channel image showed nothing in Fiji. v0.3.0-alpha.3 writes such images as grey planes (CellMigrationLab/LabConstrictor-Tools#163).

The migration moves LC_TOOLS_PIN in post_install.sh / .bat from v0.3.0-alpha.2 to v0.3.0-alpha.3, only where the line still holds the template's old value. An app's own pin is left alone and logged. This is the same code as the 0.1.28 pin move.

2. Windows Apps list: version and icon

post_install.bat registered the app in Settings > Apps with:

  • the version given at initialisation, which no release ever changed (bump_version.py looks for a PKG_VERSION line the script no longer has), and
  • the icon logo.ico, which no installer contains.

VLab4Mic, for example, showed 0.1.3 after installing 0.1.8, without an icon.

The script now reads the version at install time from the bundled construct.yaml, keeping the initialisation value as a fallback. It uses the first .ico the installer copied, and writes no icon entry when there is none. The migration replaces only the template's exact lines and keeps the app's own version; a block changed by hand is left alone, with a note. CRLF line endings are preserved.

Tests

  • test_template_sync_0_1_33.py covers: the pin, the Apps-list block, an own pin, a hand-changed block, the app's version kept, idempotence, and the sync script.
  • tests/_v0_1_33.py undoes both changes for the older migrations' tests; test_template_sync_0_1_28.py now compares through its live() helper.
  • tests/smoke/post_install_hosts.py (Windows): reads the registry back and expects version 1.2.3 from construct.yaml, not the initialisation 0.0.1, and the copied .ico.
  • With CI's versions: pytest 442 passed; ruff and mypy clean. The Linux smoke test passes all 8 cases locally, with LC_TOOLS_SPEC set to the Tools checkout. The .bat changes are exercised only by the Windows smoke job, once the tag exists.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184

Tools v0.3.0-alpha.3 writes result images of 3 or 4 planes as grey pages,
so Fiji opens them (LabConstrictor-Tools #163). The migration moves
LC_TOOLS_PIN in post_install.sh and .bat from v0.3.0-alpha.2 to
v0.3.0-alpha.3 only where the line still holds the template's old value.
tests/_v0_1_33.py moves the pin back for the older migrations' tests.

Merge only after the tag v0.3.0-alpha.3 exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184
…d the app icon

post_install.bat registered the app in Settings > Apps with the version
given at initialisation (no release changed it: bump_version.py looks
for a PKG_VERSION line the script no longer has) and the icon logo.ico,
which no installer contains. VLab4Mic showed 0.1.3 after installing
0.1.8, without an icon.

The script now reads the version from the bundled construct.yaml at
install time (the initialisation value stays as a fallback) and uses the
first .ico the installer copied; without one it writes no icon entry.
The 0.1.33 migration replaces only the template's exact lines and keeps
the app's own version. The Windows smoke test checks the registry entry
(version 1.2.3 from construct.yaml, not the 0.0.1 of initialisation).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184
@guijacquemet guijacquemet changed the title Template 0.1.33: installers use LabConstrictor-Tools v0.3.0-alpha.3 Template 0.1.33: Tools v0.3.0-alpha.3, and the right version and icon in the Windows Apps list Nov 17, 2026
@guijacquemet
guijacquemet marked this pull request as ready for review November 17, 2026 07:19
@guijacquemet
guijacquemet merged commit 1bfed12 into main Nov 17, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants